Fix parameterized UI tests for WinUI #5305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5305 +/- ##
==========================================
- Coverage 75.28% 72.91% -2.38%
==========================================
Files 601 601
Lines 37673 37672 -1
==========================================
- Hits 28363 27469 -894
- Misses 9310 10203 +893
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nohwnd
approved these changes
Mar 24, 2025
stan-sz
pushed a commit
to stan-sz/testfx
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should pass
nullso that we fallback toArgumentswhich has the right thing for parameterized tests:testfx/src/Adapter/MSTest.TestAdapter/Execution/TestMethodInfo.cs
Line 149 in d991da7
Fixes #740
It looks like we don't have the test infra that allows to test this, as we need vstest.console.exe that comes with VS. It should be possible to test it, but requires a bit of test infra work.