MM2-43 - Resend Integration #35

mjaskot · 2024-12-18T09:32:12Z

feat(emails): added email service and email templates

vholik · 2024-12-23T15:35:19Z

apps/backend/medusa-config.ts

+			}
+		}
+		// {
+    //   resolve: './src/modules/payouts',


remove this comments

vholik · 2024-12-23T15:36:52Z

apps/backend/src/modules/resend/email-templates/buyer-cancel-order.tsx

@@ -0,0 +1,23 @@
+interface EmailTemplateProps {
+  data: any


why its any?

vholik · 2024-12-23T15:36:58Z

apps/backend/src/modules/resend/email-templates/buyer-new-order.tsx

@@ -0,0 +1,111 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:37:03Z

apps/backend/src/modules/resend/email-templates/buyer-shipped-order.tsx

@@ -0,0 +1,37 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:37:06Z

apps/backend/src/modules/resend/email-templates/forgot-password.tsx

@@ -0,0 +1,22 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:37:09Z

apps/backend/src/modules/resend/email-templates/vendor-account-approved.tsx

@@ -0,0 +1,22 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:37:19Z

apps/backend/src/modules/resend/email-templates/vendor-account-updates-submission.tsx

@@ -0,0 +1,21 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:37:34Z

apps/backend/src/modules/resend/email-templates/vendor-account-updates-submission.tsx

+export const VendorAccountSubmissionEmailTemplate: React.FC<Readonly<EmailTemplateProps>> = ({ data }) => {
+  return (
+    <div>
+      <h1>Hello, {data.userName} 👋</h1>


use snake case user_name

vholik · 2024-12-23T15:37:39Z

apps/backend/src/modules/resend/email-templates/vendor-account-approved.tsx

+  return (
+    <div>
+      <h1>
+        Hello, {data.userName} 👋


use snake case

vholik · 2024-12-23T15:37:46Z

apps/backend/src/modules/resend/email-templates/forgot-password.tsx

+        new password. Please note, the link is valid for the next 24 hours only.
+      </p>
+      <div>
+        <a href={`${data.host}/resetPassword?resetPasswordToken=${data.resetPasswordToken}`}>


use snake case

vholik · 2024-12-23T15:38:15Z

apps/backend/src/modules/resend/email-templates/vendor-canceled-order.tsx

@@ -0,0 +1,19 @@
+interface EmailTemplateProps {
+  data: any


data is any

vholik · 2024-12-23T15:38:19Z

apps/backend/src/modules/resend/email-templates/vendor-new-order.tsx

@@ -0,0 +1,41 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:38:23Z

apps/backend/src/modules/resend/email-templates/vendor-new-order.tsx

+  return (
+    <div>
+      <h1>
+        {data.userName} has placed an order for {data.order.item}


vholik · 2024-12-23T15:38:27Z

apps/backend/src/modules/resend/email-templates/vendor-new-order.tsx

+        {data.userName} has placed an order for {data.order.item}
+      </h1>
+      <p>
+        New Order #{data.order.display_id} for {data.order.item}.{data.userName} has just ordered {data.order.item}.


vholik · 2024-12-23T15:38:35Z

apps/backend/src/modules/resend/email-templates/vendor-new-order.tsx

+
+      <div>
+        <p>
+          You should now ship the products to {data.userName}. The shipping address can be found in the order details.


vholik · 2024-12-23T15:38:45Z

apps/backend/src/modules/resend/email-templates/vendor-team-invite.tsx

+  return (
+    <div>
+      <h1>
+        {data.userName} has invited you to join the team at {data.storeName}.


use snake case in these file

vholik · 2024-12-23T15:38:50Z

apps/backend/src/modules/resend/email-templates/vendor-shipping-order.tsx

@@ -0,0 +1,32 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T15:38:55Z

apps/backend/src/modules/resend/email-templates/vendor-team-invite.tsx

@@ -0,0 +1,21 @@
+interface EmailTemplateProps {
+  data: any


vholik · 2024-12-23T16:05:33Z

apps/backend/src/modules/resend/service.ts

+    this.options = options
+  }
+
+  private async sendMail(subject: string, body: ReactNode, toEmail: string) {


i think it would be a lot better if we would have this provider like this

async send(notification: NotificationTypes.ProviderSendNotificationDTO) { const { data, error } = await this.resendClient.emails.send({ from: notification.from?.trim() || this.config_.from, to: notification.to, subject: notification.content?.subject, react: notification.content?.react }) if (error) { throw new MedusaError(MedusaError.Types.UNEXPECTED_STATE, error.message) } if (!data) { throw new MedusaError( MedusaError.Types.UNEXPECTED_STATE, 'No data returned by resend client' ) } return data }

have all of the email templates in the src/email-templates folder

and then use it like this in the subscriber

const notificationModuleService: INotificationModuleService = container.resolve(Modules.NOTIFICATION) await notificationModuleService.createNotifications({ to: "test@gmail.com", from: "test@medusajs.com", channel: "email", content: { react: VendorAccountRejectedEmailTemplate({ data: orderData }), } ],

we then would have a good typescript check and seperation between use case and provider

…/reject flows

…onfig from medusa-config

…eller flow

vercel · 2025-01-15T10:57:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mercur-vendor	❌ Failed (Inspect)			Jan 15, 2025 10:59am

…ercurjs#35) [MVM-403]: multiple variants list

mjaskot added the enhancement New feature or request label Dec 18, 2024

mjaskot requested a review from vholik December 18, 2024 09:32

mjaskot self-assigned this Dec 18, 2024

mjaskot requested a review from slusarczykmichal December 18, 2024 09:37

vholik reviewed Dec 23, 2024

View reviewed changes

apps/backend/medusa-config.ts Outdated

}

}

// {

// resolve: './src/modules/payouts',

Copy link

Collaborator

vholik Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comments

vholik reviewed Dec 23, 2024

View reviewed changes

mjaskot and others added 5 commits January 7, 2025 04:20

progress

09c5038

feat(seller): implemented seller registration, authentication, accept…

4fe7557

…/reject flows

feat(emails): added email service and email templates

3cd2853

fix(resend): fixed module export in index.ts, removed unecessary db c…

7952b0f

…onfig from medusa-config

chore(templates): formatted email templates with Prettier

8a2ddbc

mjaskot force-pushed the feature/MM2-43-resend-integration branch from 9ee4f55 to 8a2ddbc Compare January 7, 2025 08:55

Added migration, applied MR comments, added notification sending on s…

5a9418b

…eller flow

mjaskot changed the base branch from main to feature/MM2-87-seller-registration January 13, 2025 09:35

mjaskot mentioned this pull request Jan 13, 2025

Feature/mm2 87 Seller Registration #38

Closed

feat(seller): verify email

b44b150

vercel bot had a problem deploying to Preview January 15, 2025 10:59 Failure

slusarczykmichal changed the base branch from feature/MM2-87-seller-registration to main February 11, 2025 06:12

slusarczykmichal closed this Feb 12, 2025

slusarczykmichal deleted the feature/MM2-43-resend-integration branch February 17, 2025 09:19

LukaszMielczarek pushed a commit to LukaszMielczarek/mercur that referenced this pull request May 27, 2025

Merged in feature/MVM-403-multimvariant-products-list (pull request m…

db7c1a4

…ercurjs#35) [MVM-403]: multiple variants list

MM2-43 - Resend Integration #35

MM2-43 - Resend Integration #35

Uh oh!

Conversation

mjaskot commented Dec 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Jan 15, 2025 •

edited

Loading