Skip to content

Support Application Log collecting #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 13, 2022
Merged

Support Application Log collecting #267

merged 19 commits into from
Apr 13, 2022

Conversation

Oseenix
Copy link
Contributor

@Oseenix Oseenix commented Apr 2, 2022

No description provided.

@Oseenix Oseenix requested a review from landyking April 6, 2022 01:58
@observeralone
Copy link
Contributor

I see that many unit tests are not written, will you add them later?

@Oseenix
Copy link
Contributor Author

Oseenix commented Apr 11, 2022

I see that many unit tests are not written, will you add them later?

Let's book an online code review today

@Oseenix Oseenix merged commit b44da25 into megaease:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@observeralone observeralone observeralone approved these changes

@zhao-kun zhao-kun zhao-kun approved these changes

@landyking landyking landyking approved these changes

+1 more reviewer

@akwei akwei akwei approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oseenix @observeralone @akwei @zhao-kun @landyking