Skip to content

Conversation

chandon
Copy link
Contributor

@chandon chandon commented Jul 28, 2016

Please answer the following questions.

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #2131
BC breaks? N
Deprecations? N

Note that all new features should have a related user and/or developer documentation PR in their respective repositories.

Required

Description:

When a contact has an email but no firstname and no lastname, email is send to " " < the@email.com >.
When firstname and lastname are empty, the "To:" field should be email only, without " " and < >

Steps to test this PR:

  1. Create a user without firstname and lastname
  2. Send an email with mautic.
  3. Check To: header. Now it's To: email@email.com and not To: " " < email@email.com >

@dbhurley dbhurley added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged labels Aug 2, 2016
@dbhurley dbhurley added this to the 2.1.0 milestone Aug 2, 2016
@dbhurley
Copy link
Member

dbhurley commented Aug 2, 2016

+1

1 similar comment
@alanhartless
Copy link
Contributor

+1

@alanhartless
Copy link
Contributor

@chandon First, thanks for this!

Second, just as a FYI, I'll manually merge this to fix this, but be aware of file permissions. Files should be 0644. This PR changed the two files you edited to 0755.

@alanhartless alanhartless merged commit 338dd22 into mautic:staging Aug 3, 2016
@chandon
Copy link
Contributor Author

chandon commented Aug 3, 2016

@alanhartless thanks for the info, same problem with all my pending PR, i will try to fix them today

@chandon chandon mentioned this pull request Aug 11, 2016
aarohiprasad pushed a commit to aarohiprasad/mautic-community that referenced this pull request May 16, 2025
MAUT-11097 : Logging warnings while importing contacts or customitems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants