Fixed issue that resulted in anonymous leads not getting converted on form submit #1037
Conversation
… identified on form submit (rather a new identified lead was created)
|
I have a problem that it doesn't find the lead by tag. I confirmed in the database, that the tag had been created, lead and the tag had been linked. If I search the lead by email, I can see that it has the tag on the lead detail page. But I cannot find the lead by the tag. Doesn't matter if I search in anonymous or identified leads. Am I the only one with this issue? |
|
But apart form the tag search not working, this PR works fine. I could see in the database that before it created 2 leads and after the PR it creates only one with the correct tag. 👍 |
|
Regarding the tag search, I'm not experiencing that. Could it be a language/translation issue? Or are you using English? |
|
I used the same example as you described in the testing steps. But it's not related to this PR. It behaves the same in the staging branch as well, so we can merge this PR. |
Fixed issue that resulted in anonymous leads not getting converted on form submit
MAUT 3809 - Use segment membership as a filter for dynamic content for web
* MAUT-3602 / Operator list * Merge pull request #1037 from mautic-inc/MAUT-3809-2 MAUT 3809 - Use segment membership as a filter for dynamic content for web * Merge pull request #1339 from acquia/MAUT-5498 MAUT-5498 EAB - Segment Membership Filter in Dynamic Content Breaks Landing Pages * Changes needed after rebase to M5 * CS fixes * Allow the segment membership filter to be used by DWC * Test fixes * Fixing DWC select type filters --------- Co-authored-by: Lukas Sykora <lukassykora@seznam.cz> Co-authored-by: Lukáš Drahý <lukas@drahy.net> Co-authored-by: Rohit Pavaskar <66303837+rohitp19@users.noreply.github.com> Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Description
If an anonymous lead submitted a form, a new lead was created rather than the anonymous lead being updated. This resulted in things like tags not being applied to the form submission's lead. This fixes #1011.
Testing
tags=FormTesttag:FormTest is:anonymousand you should see an anonymous lead and note the ID. Then search for the email and should note a separate lead (different ID).Apply the PR and delete the two leads from above and repeat. This time, the anonymous lead should become the identified lead and keep all tags, etc intact.