Start 'dendron' processes directly #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a5f57e to
c99a153
Compare
clokep
reviewed
Sep 21, 2020
550ac4e to
cb30fe3
Compare
af3b79c to
d3fa8ea
Compare
richvdh
approved these changes
Oct 5, 2020
| @@ -75,11 +75,13 @@ sub _start_process | |||
| if exists $params{$_}; | |||
| } | |||
|
|
|||
| my $proc_name = $params{name} // "server"; | |||
There was a problem hiding this comment.
could you document this in the Pod?
erikjohnston
commented
Oct 6, 2020
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
added a commit
that referenced
this pull request
Feb 22, 2021
#945 removed the pydron script, but apparently failed to remove it from the dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a python script to run multiple synapse workers we may as well do that in sytest. This just makes things easier to extend.
Built on top of #943