Skip to content

Unflake "Server correctly resyncs when server leaves and rejoins a room" #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Unflake "Server correctly resyncs when server leaves and rejoins a room" #882

merged 1 commit into from
Jun 3, 2020

Conversation

anoadragon453
Copy link
Member

This test flaked on me here with the following sytest output:


# Started: 2020-06-02 16:11:09.325
# Ended: 2020-06-02 16:11:10.785
# HTTP Request failed ( 404 Not Found https://localhost:8831/_matrix/client/r0/join/!PkvlNjehVHBRXtsZBJ:localhost:8831?server_name=localhost%3A44489&access_token=MDAxY2xvY2F0aW9uIGxvY2FsaG9zdDo4ODMxCjAwMTNpZGVudGlmaWVyIGtleQowMDEwY2lkIGdlbiA9IDEKMDAzYmNpZCB1c2VyX2lkID0gQGFub24tMjAyMDA2MDJfMTU1NjM1LTc0Mzpsb2NhbGhvc3Q6ODgzMQowMDE2Y2lkIHR5cGUgPSBhY2Nlc3MKMDAyMWNpZCBub25jZSA9ID1EaCs2bUh0SEhRWThTQnMKMDAyZnNpZ25hdHVyZSCKQJ7oXgJRqAE6WliaMy8nk7YBCL8U_xChZStw-JPdxAo ) from POST https://localhost:8831/_matrix/client/r0/join/!PkvlNjehVHBRXtsZBJ:localhost:8831?...
# {"errcode":"M_NOT_FOUND","error":"Unknown room !PkvlNjehVHBRXtsZBJ:localhost:8831"}
# 0.106658: Registered new user @anon-20200602_155635-743:localhost:8831
# 0.922439: Joined room 1: !PkvlNjehVHBRXtsZBJ:localhost:8831
# 1.007631: first query response
# {
#   device_keys       => {
#                          "\@__ANON__-64:localhost:44489" => { random_device_id1 => { device_keys => {} } },
#                        },
#   failures          => {},
#   master_keys       => {},
#   self_signing_keys => {},
#   user_signing_keys => {},
# }

Looks like it was due to the room join not completing before we try to manipulate the room. Add retry_until_success to ensure we join the room before continuing further.

@anoadragon453 anoadragon453 requested a review from a team June 2, 2020 17:01
@anoadragon453 anoadragon453 merged commit 84d7cf9 into develop Jun 3, 2020
@anoadragon453 anoadragon453 deleted the anoa/unflake_device_lists_test branch June 3, 2020 14:27
pull bot pushed a commit to valkum/sytest that referenced this pull request Jun 3, 2020
@anoadragon453 @pull
Add a retry_until_success around room join (matrix-org#882)
4454996
anoadragon453 added a commit that referenced this pull request Jun 24, 2020
@anoadragon453
Merge branch 'release-v1.15.0' of github.com:matrix-org/sytest into d…
52a4818 
…insic-release-v1.15.x

* 'release-v1.15.0' of github.com:matrix-org/sytest:
  Use the standardized form for SSO login via user interactive auth. (#884)
  Add tests for room version 6. (#869)
  Add a retry_until_success around room join (#882)
  Have frontend proxy persist events when using redis (#870)
  Squashed commit of the following:
  Fix link to Synapse's contributing docs. (#879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston