Remove test which uses unspecced /events?dir=b #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've got annoyed with trying to make this test pass. It uses "events?dir=b" which isn't even specced, but it seems to expect it to block until an event arrives, which is (a) strange and (b) unreliable in a worker setup.
richvdh
commented
Jan 31, 2020
| @@ -96,8 +96,8 @@ sub test_history_visibility | |||
| } | |||
|
|
|||
| foreach my $i ( | |||
| [ "Guest", sub { guest_user_fixture( with_events => 1 ) } ], | |||
| [ "Real", sub { local_user_fixture( with_events => 1 ) } ] | |||
| [ "Guest", sub { guest_user_fixture() } ], | |||
There was a problem hiding this comment.
guest_user_fixture doesn't do anything with its params
richvdh
commented
Jan 31, 2020
| [ "Guest", sub { guest_user_fixture( with_events => 1 ) } ], | ||
| [ "Real", sub { local_user_fixture( with_events => 1 ) } ] | ||
| [ "Guest", sub { guest_user_fixture() } ], | ||
| [ "Real", sub { local_user_fixture() } ] |
There was a problem hiding this comment.
local_user_fixture does take a with-events param: it makes it call /events to initialise an eventstream_token field in the user... which we weren't using.
erikjohnston
approved these changes
Jan 31, 2020
anoadragon453
added a commit
that referenced
this pull request
Mar 23, 2020
…ease-v1.10.x * origin/release-v1.10.0: remove checks on m.room.aliases (#801) Remove test which uses unspecced /events?dir=b (#794) Add some tests to check for adding/removing aliases (#792) Add test for ensuring power levels are correctly handled during upgrade (#777) Test that fetching device correctly resyncs (#791) Add support for experimental MSC2260 room version (#790) Fix power levels being sent as strings (#789) Don't respond with 503 as server will be marked as down. (#788) Test Synapse with MAU limits enabled. (#782) Fix docker/push.sh and make it echo commands Change postgres in docker image to use C collation/ctype. (#783) Add a passing test for recovery from gappy device list updates (#761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got annoyed with trying to make this test pass. It uses "/events?dir=b"
which isn't even specced, but it seems to expect it to block until an event
arrives, which is (a) strange and (b) unreliable in a worker setup.