This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make localization keys compatible with agglutinative and/or SOV type languages #10159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
commented
Feb 14, 2023
| @@ -1574,8 +1574,8 @@ | |||
| "FAQ": "FAQ", | |||
| "Keyboard Shortcuts": "Keyboard Shortcuts", | |||
| "Versions": "Versions", | |||
| "Homeserver is": "Homeserver is", | |||
There was a problem hiding this comment.
The position of verbs should not be hard coded.
…native and/or SOV type languages Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
… compatible with agglutinative and/or SOV type languages Make keys compatible with inflection Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
justjanne
reviewed
Feb 16, 2023
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
|
(#10159 (comment) I didn't notice that asking a review from more than one reviewer was not possible) |
justjanne
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This PR makes localization keys compatible with agglutinative and/or SOV (Subject Object Verb) type languages, clarifying context with variables, to improve localization experience on Weblate.
type: defect
element-web notes: none
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes