Skip to content

Fix tests to not depend on unspecced room_id parameter for each child room. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix tests to not depend on unspecced room_id parameter for each child room. #422

merged 1 commit into from
Jul 25, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 22, 2022 •
edited
Loading

The /hierarchy response should not return a room_id in each entry in the children_state array. This ensures we're not using this (and are using the room_id from the parent object).

Fixes #416

For cross-referencing:

This was referenced Jul 22, 2022
Closed
Merged
@clokep clokep marked this pull request as ready for review July 22, 2022 17:55
@clokep clokep requested review from a team July 22, 2022 17:55
neilalexander
neilalexander approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clokep clokep merged commit 6d056d4 into main Jul 25, 2022
@clokep clokep deleted the clokep/hierarchy-room-id-2 branch July 25, 2022 12:19
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

+1 more reviewer

@neilalexander neilalexander neilalexander approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly tests the results of MSC2946 /hierarchy response
3 participants
@clokep @neilalexander @kegsay