The tests for the /hierarchy endpoint are incorrect in that they assume each entry in children_state includes a room_id field. This was removed from MSC2946 at some point, but was never updated in complement.

Synapse no longer depends on this field as of matrix-org/synapse#12991, but still returns it. I assume Dendrite also returns it since those tests are skipped there.

I believe this would affect:

• room_hierarchy_test.go
• restricted_room_hierarchy_test.go

To test using Synapse I was running the following in my Synapse checkout:

$ COMPLEMENT_DIR=~/matrix/complement ./scripts-dev/complement.sh -run "TestClientSpacesSummary|TestClientSpacesSummaryJoinRules|TestFederatedClientSpaces|TestRestrictedRoomsSpacesSummaryLocal|TestRestrictedRoomsSpacesSummaryFederation"