Update vdW radii to CRC handbook values #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git does not seem well-equipped to diff https://jsoncompare.com/#!/diff/id=6924b719277a2a2b7a630352828d155c&fullscreen/ click the 'lint' button on both panes and you will see each change nicely highlighted |
|
Thank you @rkingsbury , definitely happy to have data sourced from somewhere that isn't wikipedia here :-) |
DanielYang59
added a commit
to DanielYang59/pymatgen
that referenced
this pull request
Apr 21, 2025
DanielYang59
added a commit
to DanielYang59/pymatgen
that referenced
this pull request
Apr 21, 2025
1 task
shyuep
pushed a commit
that referenced
this pull request
Apr 21, 2025
…ook (#4372) * add new values that are absent from CSV at all * remove fixed issues * regenerate json and yaml * add Ge vdw radius * remove legacy electron_affinities.yaml * manually recover electron affinities for D for now * reapply update from #2122 * Revert "Fix inconsistent "Van der waals radius" and "Metallic radius" in `core.periodic_table.json` (#4345)" This reverts commit bdc448f. * add note * revert changes to metallic radii * revert change to metallic radii in production json * fix Pa vdw radius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
van_der_waals_radiusdata used by theElementclass from Wikipedia data to the latest values in the in the CRC Handbook of Chemistry and Physics. Important changes from the previous values include:Hdown by 0.1 angstrom as recommended in a critical review by Rowland and TaylorAll data, and the justification for which values were chosen, can be found in
"Atomic Radii of the Elements" in CRC Handbook of Chemistry and Physics, 91st Ed.; Haynes, W.M., Ed.; CRC Press: Boca Raton, FL, 2010.