Skip to content

Fix version truncation for client hints #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix version truncation for client hints #7138

merged 1 commit into from
Jun 10, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2022 •
edited
Loading

When the browser or os version is detected using client hints, the version is currently not truncated using the configured version truncation.

@sgiehl sgiehl marked this pull request as ready for review June 10, 2022 06:47
@sgiehl sgiehl requested a review from sanchezzzhak June 10, 2022 06:47
sanchezzzhak
sanchezzzhak approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@sanchezzzhak sanchezzzhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched it yesterday.
it looks good

@sgiehl sgiehl merged commit ec95993 into master Jun 10, 2022
@sgiehl sgiehl deleted the versiontruncation branch June 10, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezzzhak sanchezzzhak sanchezzzhak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @sanchezzzhak