Add Amazonbot and simplify some bot regexes #6843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchezzzhak
reviewed
Sep 8, 2021
sanchezzzhak
previously approved these changes
Sep 8, 2021
|
Ah wait, sorry, now I found a missing user agent: Sorry for the back and forth, background is that two pages got a several thousand percent increase, clearly associated to bot activity, so I checked our access logs and compared user agents. I'm not sure if that one executes JavaScript and sends tracker requests, but it is extremely active on our website (~100,000 daily requests compared to ~5,000 by Googlebot). In the current access logs (not much more than one day), it does not send tracker requests, but it does access exactly massively the two pages which got this high increase. |
sanchezzzhak
requested changes
Sep 8, 2021
Amazonbot is Amazon's web crawler: https://developer.amazon.com/support/amazonbot The third option of the Baiduspider regex supersedes the first, and hence both are combined. While regexes are checked case-insensitive, it is changed to capital B for consistency with the other patterns, which have correct cases consequently. All cases of leading and tailing "(...)?" optional strings have been removed, as they don't have any effect on whether a string matches or not. Optional characters are only relevant when being surrounded by non-optional characters. Signed-off-by: MichaIng <micha@dietpi.com>
sanchezzzhak
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Amazonbot is Amazon's web crawler: https://developer.amazon.com/support/amazonbot
The third option of the Baiduspider regex supersedes the first, and hence both are combined. While regexes are checked case-insensitive, it is changed to capital B for consistency with the other patterns, which have correct cases consequently.
All cases of leading and tailing
(...)?optional strings have been removed, as they don't have any effect on whether a string matches or not. Optional characters are only relevant when being surrounded by non-optional characters.Review