Improves detection for various devices #5911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves detection of AllCall, AllView, CUBOT, Evolio, Google, Huawei, Karbonn, M4tel, NYX Mobile, Nokia, Oppo, Sharp, Sony, Timovi, ZTE devices
sgiehl
requested changes
Feb 11, 2019
regexes/device/mobiles.yml
Outdated
| @@ -7057,7 +7181,7 @@ Spice: | |||
|
|
|||
| # Sharp | |||
| Sharp: | |||
| regex: 'SHARP|SBM|SH-?[0-9]+[a-z]?[);/ ]|AQUOS|506SH|SHL22 ' | |||
| regex: 'SHARP|SBM|SH-?[0-9]+[a-z]?[);/ ]|AQUOS|506SH|SHL22|FS8010 ' | |||
There was a problem hiding this comment.
Actually I'm nor sure if the in the end of SHL22 was there on purpose. But as there are no tests that fail I guess it wasn't. Nevertheless I think it might be better to match exact model fragments like SHL22 or FS8010 with a [);/ ] in the end, so it doesn't match anything with additional chars
regexes/device/mobiles.yml
Outdated
| @@ -7399,6 +7525,10 @@ Timovi: | |||
| regex: 'Tmovi' | |||
| device: 'smartphone' | |||
| models: | |||
| - regex: 'Prime' | |||
There was a problem hiding this comment.
Might be better to use Tmovi[ _]Prime, so it also matches Mozilla/5.0 (Linux; U; Android 4.4.2; es-LA; Tmovi_Prime Build/KOT49H) AppleWebKit/528.5+ (KHTML, like Gecko) Version/3.1.2 Mobile Safari/525.20.1 UCBrowser/9.7.0.520 Mobile
sgiehl
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves detection of AllCall, AllView, CUBOT, Evolio, Google, Huawei, Karbonn, M4tel, NYX Mobile, Nokia, Oppo, Sharp, Sony, Timovi, ZTE devices