Skip to content

Improves detection for lcatel, Blackview, Blu, Crosscall, E-Boda, Elephone, Hyundai, MyPhone, Oppo, Sky, Tecno Mobile, Ulefone, Vonino, Wiko, Xiaomi, ZTE, Zuum devices #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2019
Merged

Improves detection for lcatel, Blackview, Blu, Crosscall, E-Boda, Elephone, Hyundai, MyPhone, Oppo, Sky, Tecno Mobile, Ulefone, Vonino, Wiko, Xiaomi, ZTE, Zuum devices #5905

merged 2 commits into from
Feb 10, 2019

Conversation

liviuconcioiu
Copy link
Collaborator

Improves detection of Alcatel, Blackview, Blu, Crosscall, E-Boda, Elephone, Hyundai, MyPhone, Oppo, Sky, Tecno Mobile, Ulefone, Vonino, Wiko, Xiaomi, ZTE, Zuum devices

@liviuconcioiu
Improves detection for various devices
227d7c9 
Improves detection of Alcatel, Blackview, Blu, Crosscall, E-Boda, Elephone, Hyundai, MyPhone, Oppo, Sky, Tecno Mobile, Ulefone, Vonino, Wiko, Xiaomi, ZTE, Zuum devices
sgiehl
sgiehl requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left a few minor comments

@liviuconcioiu
Copy link
Collaborator Author

Fixed

@sgiehl sgiehl merged commit d43c867 into matomo-org:master Feb 10, 2019
@mattab mattab changed the title Improves detection for various devices Improves detection for lcatel, Blackview, Blu, Crosscall, E-Boda, Elephone, Hyundai, MyPhone, Oppo, Sky, Tecno Mobile, Ulefone, Vonino, Wiko, Xiaomi, ZTE, Zuum devices Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviuconcioiu @sgiehl