Skip to content

Add Oppo smartphones: PACM00, and PACT00 #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

Add Oppo smartphones: PACM00, and PACT00 #5822

merged 1 commit into from
Oct 5, 2018

Conversation

pongee
Copy link
Contributor

@pongee pongee commented Oct 5, 2018

@sgiehl sgiehl merged commit 330c6fd into matomo-org:master Oct 5, 2018
mimmi20
mimmi20 reviewed Oct 5, 2018
View reviewed changes
regexes/device/mobiles.yml
@@ -4900,6 +4900,8 @@ OPPO:
model: 'F1s'
- regex: '(?:OPPO[ _]?)?R1011 Build'
model: 'Joy Plus'
- regex: '(?:OPPO[ _]?)?PAC[T|M]00 Build'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches PAC|00 Build too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, will change that

@pongee pongee deleted the dev branch May 7, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

+1 more reviewer

@mimmi20 mimmi20 mimmi20 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pongee @mimmi20 @sgiehl