Adds detection for Impression, Vinsoc and Zync devices #5872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or 6X version AL30, Wooze I5, Wooze 7
sgiehl
requested changes
Nov 25, 2018
| @@ -3524,7 +3532,7 @@ INQ: | |||
|
|
|||
| # Intex | |||
| Intex: | |||
| regex: 'Intex|(Aqua|Cloud)[ _\.]([^/;\)]+)(?:[ _]Build|(?<!Build)/|\))' | |||
| regex: 'Intex|(Aqua|Cloud[ _][XY][0-9]{1})' | |||
There was a problem hiding this comment.
Any reason for changing this one?
There was a problem hiding this comment.
Conflict regular expression in Zync devices:
1
user_agent: Mozilla/5.0 (Linux; U; Android 4.2.2; en-us; ZYNC CLOUD 605 Build/JDQ39) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30
2
user_agent: Mozilla/5.0 (Linux; U; Android 4.0.4; en-us; Cloud Z5 Build/IMM76D) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 UCBrowser/9.4.1.362 U3/0.8.0 Mobile Safari/533.1
There was a problem hiding this comment.
Ok. But your changes also affect the Aqua detection, which is now less restrictive as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.