PHP 7 compatible PclZip version #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
pushed a commit
that referenced
this pull request
Sep 22, 2015
PHP 7 compatible PclZip version
This was referenced Sep 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #4 this version is compatible with PHP 7. Tar still remains incompatible for now.
I took the PclZip version from https://github.com/ivanlanin/pclzip as the latest one (2.8.2) from http://www.phpconcept.net/pclzip/pclzip-downloads is not PHP 7 ready yet.
I was a bit confused to be honest. As https://github.com/ivanlanin/pclzip is supposed to be just a clone to have it in composer there's quite a big difference between this version and the one on phpconcept. I compared the versions to bring more light into this and it looks like in the new version many whitespaces were changed, visibility like
publicwas added, etc