Skip to content

Test enhancement #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add php-7.2 and php-7.3 tests on Travis CI build.
  • Removing --dev option because this option is deprecated on latest composer version.
    The deprecated warning message is as follows:
You are using the deprecated option "dev". Dev packages are installed by default now.
  • Using the assertNull to assert that the expected value is same as null.
  • According to the .travis.yml setting, the minimal PHP version test is 5.4.
    Modify the php version requirement to be >=5.4 inside require block on composer.json.

@tsteur tsteur merged commit eb4c957 into matomo-org:master Nov 5, 2019
@tsteur
Copy link
Member

tsteur commented Nov 5, 2019

cheers @peter279k very appreciated 👍

@peter279k peter279k deleted the test_enhancement branch November 6, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants