Fix signout; return error instead of crash from signin
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from macOS High Sierra 10.13.3 (17D2047)
Added nonnull markers
Gets rid of warning: Target Quick product libQuick.a cannot link framework XCTest.framework
Closed
Generated by 🚫 Danger |
Removes the need for unwrap
This was referenced Aug 11, 2018
Merged
signout; return error instead of crash from signin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a fix for the root cause but prevents a crash whenever the
signincommand is used on newer versions of macOS (10.13+). Users running older macOS versions (10.9-10.12) are unaffected.Resolves the crasher reported in #107. See #164 for more details.