Skip to content

fix bold or italic hyperlinks can't be opened through Cmd+Click #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2020
Merged

fix bold or italic hyperlinks can't be opened through Cmd+Click #1810

merged 2 commits into from
Feb 6, 2020

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Dec 12, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets Fixes #1698
License MIT

Description

fix bold or italic hyperlinks can't be opened through Cmd+Click

@MrHeer
Copy link
Contributor Author

MrHeer commented Dec 12, 2019

I know it ugly, but I can't find a better solution.

@Jocs
Copy link
Member

Jocs commented Dec 12, 2019

@MrHeer Your PR solve this syntax [**strong**](), it maybe also has other cases like:

[`inline code`]()

[~~line through~~]()

[**`inline and strong`**]()

So, get parentNode is not enough?

Jocs
Jocs requested changes Dec 12, 2019
View reviewed changes
@MrHeer MrHeer requested a review from Jocs December 21, 2019 00:01
@Jocs Jocs merged commit 632eac3 into marktext:develop Feb 6, 2020
@Jocs
Copy link
Member

Jocs commented Feb 6, 2020

@MrHeer Thanks for your contribution!

@MrHeer MrHeer deleted the fix-hyperlinks branch February 7, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jocs Jocs Jocs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not open bold or italic hyperlinks through Cmd+Click
2 participants
@MrHeer @Jocs