add gcs support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maorfr Let's do that, I'll get a PR ready for helm/charts on Monday! |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as nuvo/skbn and nuvo/cain have gone un-maintained , both have been forked to maorfr/skbn and maorfr/cain respectively.
helm/charts/incubator/cassandra should be updated to use maorfr/cain instead of nuvo/cain.
@Simon3, @mr-smithers-excellent,
thanks for getting involved with this project!
@Simon3, I have cherry picked your commit to skbn, and updating cain accordingly here.
would you like to make the contribution to helm/charts yourself so you can be added to the list of contributors?
btw, really liked your implementation!