updating Context backtrack for new leaf misses. #482
Conversation
CodSpeed Performance ReportMerging #482 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
===========================================
+ Coverage 49.15% 62.27% +13.11%
===========================================
Files 33 35 +2
Lines 2079 2330 +251
===========================================
+ Hits 1022 1451 +429
+ Misses 1057 879 -178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @martin-juhlin, would you mind rebasing your branch to be in sync with |
when matching similary pattern, this will update the Content::backtrack to incoming nodes miss value, if the miss is pointing to a leaf node, meaning if somehting fail later on, it can go expected value. adding some new test cases to verify that the new logic is working.
|
HI, @jeertmans, sure, no problem. I done an update :) |
|
Looks like your PR fixes way more issues than anticipated! I tested and it also fixes #279. That might be worth checking all issues that are fixed by the long-running issue, but it can also take some time ^^' Anyway, happy you came up with a solution! |
|
Is there anything that's blocking this PR from being merged? |
|
Not really blocking, I was just hoping we could invest some more time and test if other issues can be closed thanks to this fix. I would really appreciate it if someone could, for each of the bugs, check if that bug can solved by this PR and, if so, write a test that shows that the bug is now fixed. Similar to what is done here, but only for 3 issues. |
|
I see. What about publishing a pre-release version with this merged so we can ask the authors of said issues if they can update to the pre-release and if that fixes things / changes the behaviour? Might speed up the process. |
Hmm I don't have much time to spend on this, and not enough to, so I fear I would just forget about it or postpone this. I would prefer addressing this issue now ^^' |
when matching similary pattern, this will update the Content::backtrack to incoming nodes miss value, if the miss is pointing to a leaf node, meaning if somehting fail later on, it can go expected value.
adding some new test cases to verify that the new logic is working.