Skip to content

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Aug 12, 2025

In #19127 I converted fse.watchFile to fs.promises.watchFile, which apparently doesn't exist.

Revert to using the synchronous fs.watchFile to fix this issue, although we should probably be using fs.promises.watch:

Using fs.watch() is more efficient than fs.watchFile and fs.unwatchFile. fs.watch should be used instead of fs.watchFile and fs.unwatchFile when possible.

I'll move this to fs.watch in a follow-up PR.

@mui-bot
Copy link

mui-bot commented Aug 12, 2025

Deploy preview: https://deploy-preview-19151--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 4bbcff6

@bernardobelchior bernardobelchior changed the title [infra] Fix fs.promises.watch [infra] Fix fs.promises.watchFile Aug 12, 2025
@bernardobelchior bernardobelchior added type: bug It doesn't behave as expected. scope: code-infra Changes related to the core-infra product. labels Aug 12, 2025
@bernardobelchior bernardobelchior marked this pull request as ready for review August 12, 2025 08:49
@bernardobelchior
Copy link
Member Author

Superseded by #19148

@bernardobelchior bernardobelchior deleted the fix-fs-promises-watch branch August 13, 2025 09:26
@zannager zannager changed the title [infra] Fix fs.promises.watchFile [code-infra] Fix fs.promises.watchFile Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Changes related to the core-infra product. type: bug It doesn't behave as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants