[code-infra] Replace fs-extra with node:fs calls
#19148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,7 +188,6 @@ async function main() { | |||
| it('should position the headers matching the columns', async () => { | |||
| const route = '/docs-data-grid-virtualization/ColumnVirtualizationGrid'; | |||
| const screenshotPath = path.resolve(screenshotDir, `.${route}ScrollLeft400px.png`); | |||
| await fse.ensureDir(path.dirname(screenshotPath)); | |||
There was a problem hiding this comment.
emptyDir already ensures screenshotDir is available, so I don't think we need to check again.
It's true that something might have deleted it, but since these are tests they will fail and I suppose that's fine.
fs-extra with node:fs calls
|
Deploy preview: https://deploy-preview-19148--material-ui-x.netlify.app/ Bundle size report
|
brijeshb42
approved these changes
Aug 12, 2025
fs-extra with node:fs callsfs-extra with node:fs calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
fs-extrawithnode:fscalls.We still depend on
fs-extratransitively since@mui/monorepodepends on it.