Skip to content

[charts] Fix Heatmap docs duplicate text #19138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[charts] Fix Heatmap docs duplicate text #19138

merged 1 commit into from
Aug 11, 2025

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas self-assigned this Aug 11, 2025
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Aug 11, 2025
@JCQuintas JCQuintas enabled auto-merge (squash) August 11, 2025 15:21
@mui-bot
Copy link

mui-bot commented Aug 11, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19138--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 63bb4a1

bernardobelchior
bernardobelchior approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that "the only difference of the heatmap tooltip" is in comparison to?

We mean the scatter/bar/line tooltip, but we should probably be more specific about it.

What do you think?

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19138 will improve performances by 8.86%

Comparing JCQuintas:heatmap-text (63bb4a1) with master (44aeba4)1

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ ScatterChartPro with big data amount 437.1 ms 401.5 ms +8.86%

Footnotes

  1. No successful run was found on master (b8b0bd3) during the generation of this report, so 44aeba4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@JCQuintas JCQuintas merged commit c4eab0d into mui:master Aug 11, 2025
25 checks passed
@JCQuintas JCQuintas deleted the heatmap-text branch August 11, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette is a code owner

Assignees

@JCQuintas JCQuintas

Labels
scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JCQuintas @mui-bot @bernardobelchior