-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[charts] Add all planned charts on the overview page #19077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview: https://deploy-preview-19077--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
CodSpeed Performance ReportMerging #19077 will improve performances by 9.36%Comparing Summary
Benchmarks breakdown
Footnotes |
srcDark: '/static/x/component-illustrations/treemap-dark.png', | ||
href: '/x/react-charts/treemap/', | ||
planned: true, | ||
pro: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pricing page on material-ui repository shoudl be updated too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made two sections and also removed component illustrations. |
I would probably make them a grid of cards rather than a list, we can then style the existing ones blue-ish as the feature cards above without the icons though, and the planned ones with a gray-ish background instead? long lists are boring 😆 |
Agree, I just wanted to give a break to the user as the entire page is already quite overwhelming. Also, this is a faster implementation while styling icons/illustrations can take time, we can do a revamp later if needed. |
I've not added individual docs pages because a user would quickly like to see the chart which is only on Github. It also helps get the upvote faster.
https://deploy-preview-19077--material-ui-x.netlify.app/x/react-charts/#all-mui-x-charts