Skip to content

[charts] Fix type assertion in axis highlight components #19060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 5, 2025
Merged

[charts] Fix type assertion in axis highlight components #19060

merged 5 commits into from
Aug 5, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 5, 2025

This PR removes unnecessary @ts-expect-error checks

@sai6855 sai6855 added typescript type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Aug 5, 2025
sai6855 and others added 3 commits August 5, 2025 15:16
@sai6855
Merge remote-tracking branch 'upstream/master' into charts-ts-expect-…
484d2e7 
…error
@sai6855
Update ChartsXAxisHighlight.tsx
51f409b 
Signed-off-by: sai chand <60743144+sai6855@users.noreply.github.com>
@sai6855
Update ChartsYAxisHighlight.tsx
9c34db2 
Signed-off-by: sai chand <60743144+sai6855@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Aug 5, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19060--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid/DataGrid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro/DataGridPro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium/DataGridPremium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 2f57291

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19060 will not alter performance

Comparing sai6855:charts-ts-expect-error (2f57291) with master (84d7fb4)1

Summary

✅ 10 untouched benchmarks

Footnotes

  1. No successful run was found on master (843c35f) during the generation of this report, so 84d7fb4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bernardobelchior
bernardobelchior approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bernardobelchior bernardobelchior merged commit d9f860d into mui:master Aug 5, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette is a code owner

@JCQuintas JCQuintas Awaiting requested review from JCQuintas JCQuintas is a code owner

Assignees
No one assigned
Labels
scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @bernardobelchior