[charts-pro] Refactor createAxisFilterMapper
#18998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-18998--material-ui-x.netlify.app/ Bundle size report
|
| const axisData = ['I0', 'I1', 'I2', 'I3']; | ||
| const filter = createDiscreteScaleGetAxisFilter(axisData, 24, 76, 'y'); | ||
|
|
||
| expect(filter({ x: null, y: 'I0' }, 0)).toBe(false); |
There was a problem hiding this comment.
Here I0 and I3 are partially visible, so they should be included.
This is fixed in #18992.
createAxisFilterMapper
CodSpeed Performance ReportMerging #18998 will not alter performanceComparing Summary
|
alexfauquette
approved these changes
Jul 31, 2025
Comment on lines
89
to
92
| const max = (axisData?.length ?? 1) - 1; | ||
|
|
||
| [min, max] = getScale(continuousScaleType, extremums, [0, 100]).nice().domain(); | ||
| const minVal = (zoomStart * max) / 100; | ||
| const maxVal = (zoomEnd * max) / 100; |
There was a problem hiding this comment.
Just to clarify what kind of max it is
Suggested change
| const max = (axisData?.length ?? 1) - 1; | |
| [min, max] = getScale(continuousScaleType, extremums, [0, 100]).nice().domain(); | |
| const minVal = (zoomStart * max) / 100; | |
| const maxVal = (zoomEnd * max) / 100; | |
| const maxIndex = (axisData?.length ?? 1) - 1; | |
| const minVal = (zoomStart * maxIndex) / 100; | |
| const maxVal = (zoomEnd * maxIndex) / 100; |
JCQuintas
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the functions for creating the axis filters. Now there's one for discrete scales and another one for continuous ones. It makes them easier to test and reason about IMO.
Also added tests.
I did this refactor as a precursor to a bug fix (PR here), but I want to test that PR more thoroughly first, so I moved the refactor into this PR.