[charts-pro] Export ChartsWrapper from './ChartsWrapper' rather than './internals'
#18966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-18966--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
CodSpeed Performance ReportMerging #18966 will not alter performanceComparing Summary
Footnotes |
bernardobelchior
approved these changes
Jul 30, 2025
Comment on lines
1
to
14
| import { | ||
| ChartsWrapper as OriginalChartsWrapper, | ||
| ChartsWrapperProps as OriginalChartsWrapperProps, | ||
| } from '../ChartsWrapper'; | ||
| /** | ||
| * @deprecated Use `ChartsWrapper` from `@mui/x-charts/ChartsWrapper` instead. | ||
| * This will be removed in the next major version. | ||
| */ | ||
| export const ChartsWrapper = OriginalChartsWrapper; | ||
| /** | ||
| * @deprecated Use `ChartsWrapperProps` from `@mui/x-charts/ChartsWrapper` instead. | ||
| * This will be removed in the next major version. | ||
| */ | ||
| export type ChartsWrapperProps = OriginalChartsWrapperProps; |
There was a problem hiding this comment.
This is the internals directory. Do we need to re-export the file? I was under the impression that content under internals isn't guaranteed not to change within majors.
Still, if we want to keep it, it's probably better to add a task here.
ChartsWrapper from packageChartsWrapper from './ChartsWrapper' rather than './internals'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we use
ChartsWrapperin some demos, though that was meant as an internal component. Eg: https://mui.com/x/react-charts/pie/#compositionDue to recent changes to it, it might be better if we properly export it so users can have the same functionality in their composition as our default charts, if they want it ofc