[charts-pro] Fix slotProps.tooltip.trigger not respected in ScatterChartPro and FunnelChart
#18902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-18902--material-ui-x.netlify.app/ Bundle size report
|
CodSpeed Performance ReportMerging #18902 will not alter performanceComparing Summary
|
JCQuintas
reviewed
Jul 24, 2025
| @@ -109,7 +109,7 @@ const FunnelChart = React.forwardRef(function FunnelChart( | |||
| <ChartsAxis {...chartsAxisProps} /> | |||
| {children} | |||
| </ChartsSurface> | |||
| {!themedProps.loading && <Tooltip {...themedProps.slotProps?.tooltip} trigger="item" />} | |||
| {!themedProps.loading && <Tooltip trigger="item" {...themedProps.slotProps?.tooltip} />} | |||
There was a problem hiding this comment.
Yeah the idea was to remove the possibility of changing it, IMO we could check for trigger={themedProps.slotProps?.tooltip === 'none' ? 'none' : 'item'}
There was a problem hiding this comment.
I was considering changing the props so that "axis" isn't a valid option for scatter and funnel. Wouldn't that work as well?
The user can still provide "axis" if they want to, but they can provide any string really.
JCQuintas
approved these changes
Jul 25, 2025
alexfauquette
approved these changes
Jul 29, 2025
| @@ -22,15 +22,16 @@ import { useSvgRef } from '../hooks'; | |||
|
|
|||
| const noAxis = () => false; | |||
|
|
|||
| export interface ChartsTooltipContainerProps extends Partial<PopperProps> { | |||
| export interface ChartsTooltipContainerProps<T extends TriggerOptions = TriggerOptions> | |||
| extends Partial<PopperProps> { | |||
| /** | |||
| * Select the kind of tooltip to display | |||
| * - 'item': Shows data about the item below the mouse. | |||
| * - 'axis': Shows values associated with the hovered x value | |||
There was a problem hiding this comment.
Now it can also be y values for horizontal bar chart and rotation for radar chart
Suggested change
| * - 'axis': Shows values associated with the hovered x value | |
| * - 'axis': Shows values associated with the hovered axis value. |
| @@ -22,15 +22,16 @@ import { useSvgRef } from '../hooks'; | |||
|
|
|||
| const noAxis = () => false; | |||
|
|
|||
| export interface ChartsTooltipContainerProps extends Partial<PopperProps> { | |||
| export interface ChartsTooltipContainerProps<T extends TriggerOptions = TriggerOptions> | |||
| extends Partial<PopperProps> { | |||
| /** | |||
| * Select the kind of tooltip to display | |||
| * - 'item': Shows data about the item below the mouse. | |||
| * - 'axis': Shows values associated with the hovered x value | |||
| * - 'none': Does not display tooltip | |||
There was a problem hiding this comment.
Suggested change
| * - 'none': Does not display tooltip | |
| * - 'none': Does not display tooltip. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f39ec4f to
0788cb7
Compare
0788cb7 to
107f365
Compare
107f365 to
661936e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18900.
Before
See videos in #18900.
After
ScatterChartProScreen.Recording.2025-07-24.at.18.15.44.mov
FunnelChartScreen.Recording.2025-07-24.at.18.15.21.mov