[charts] Fix crash when rendering large scatter dataset #18845

bernardobelchior · 2025-07-18T12:37:41Z

Part of #12960.

Fix an issue where scatter charts with 1 million data points would crash with "Maximum call stack size exceeded".

mui-bot · 2025-07-18T12:39:55Z

Deploy preview: https://deploy-preview-18845--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 🔺+440B^(0.00%) - Total Gzip Change: 🔺+1.23KB^(+0.03%)
Files: 122 total (0 added, 0 removed, 28 changed)

Show details for 100 more bundles (22 more not shown)

@mui/x-charts-pro/PieChartPro parsed: 🔺+28B^(+0.01%) gzip: 🔺+68B^(+0.09%)
@mui/x-charts/LineChart parsed: 🔺+26B^(+0.01%) gzip: 🔺+79B^(+0.11%)
@mui/x-charts/PieChart parsed: 🔺+26B^(+0.01%) gzip: 🔺+76B^(+0.12%)
@mui/x-charts/SparkLineChart parsed: 🔺+26B^(+0.01%) gzip: 🔺+70B^(+0.11%)
@mui/x-charts-pro parsed: 🔺+22B^(+0.01%) gzip: 🔺+74B^(+0.06%)
@mui/x-charts-pro/BarChartPro parsed: 🔺+22B^(+0.01%) gzip: 🔺+28B^(+0.03%)
@mui/x-charts-pro/ChartContainerPro parsed: 🔺+22B^(+0.01%) gzip: 🔺+73B^(+0.13%)
@mui/x-charts-pro/ChartDataProviderPro parsed: 🔺+22B^(+0.01%) gzip: 🔺+55B^(+0.10%)
@mui/x-charts-pro/FunnelChart parsed: 🔺+22B^(+0.01%) gzip: 🔺+83B^(+0.11%)
@mui/x-charts-pro/Heatmap parsed: 🔺+22B^(+0.01%) gzip: 🔺+67B^(+0.09%)
@mui/x-charts-pro/LineChartPro parsed: 🔺+22B^(+0.01%) gzip: 🔺+43B^(+0.05%)
@mui/x-charts-pro/ScatterChartPro parsed: 🔺+22B^(+0.01%) gzip: 🔺+32B^(+0.04%)
@mui/x-charts parsed: 🔺+20B^(+0.01%) gzip: 🔺+70B^(+0.08%)
@mui/x-charts-pro/RadarChartPro parsed: 🔺+20B^(+0.01%) gzip: 🔺+61B^(+0.10%)
@mui/x-charts/BarChart parsed: 🔺+20B^(+0.01%) gzip: 🔺+75B^(+0.11%)
@mui/x-charts/ChartContainer parsed: 🔺+20B^(+0.01%) gzip: 🔺+71B^(+0.15%)
@mui/x-charts/ChartDataProvider parsed: 🔺+20B^(+0.01%) gzip: 🔺+68B^(+0.15%)
@mui/x-charts/Gauge parsed: 🔺+20B^(+0.01%) gzip: 🔺+30B^(+0.07%)
@mui/x-charts/RadarChart parsed: 🔺+20B^(+0.01%) gzip: 🔺+75B^(+0.13%)
@mui/x-charts/ScatterChart parsed: 🔺+20B^(+0.01%) gzip: 🔺+28B^(+0.05%)
@mui/x-charts-pro/ChartZoomSlider parsed: ▼-2B^(0.00%) gzip: 🔺+1B^(0.00%)
@mui/x-charts-pro/ChartsToolbarPro parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsAxis parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsAxisHighlight parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsClipPath parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsGrid parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsLabel parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsLegend parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsLocalizationProvider parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsOverlay parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsReferenceLine parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsSurface parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsText parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsTooltip parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsXAxis parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/ChartsYAxis parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-charts/Toolbar parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-data-grid parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-data-grid-premium parsed: 0B^(0.00%) gzip: ▼-1B^(0.00%)
@mui/x-data-grid-premium/DataGridPremium parsed: 0B^(0.00%) gzip: 🔺+1B^(0.00%)
@mui/x-data-grid-pro parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-data-grid-pro/DataGridPro parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-data-grid/DataGrid parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro parsed: 0B^(0.00%) gzip: 🔺+1B^(0.00%)
@mui/x-date-pickers-pro/AdapterDateFns parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterDateFnsJalali parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterDayjs parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterLuxon parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterMoment parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterMomentHijri parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/AdapterMomentJalaali parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DateRangeCalendar parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DateRangePicker parsed: 0B^(0.00%) gzip: ▼-1B^(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay2 parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DateTimeRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DesktopDateRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/DesktopDateTimeRangePicker parsed: 0B^(0.00%) gzip: 🔺+1B^(0.00%)
@mui/x-date-pickers-pro/DesktopTimeRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/LocalizationProvider parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MobileDateRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MobileDateTimeRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MobileTimeRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MultiInputDateRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MultiInputDateTimeRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/MultiInputTimeRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/PickersRangeCalendarHeader parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/SingleInputDateRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/SingleInputDateTimeRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/SingleInputTimeRangeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers-pro/StaticDateRangePicker parsed: 0B^(0.00%) gzip: ▼-1B^(0.00%)
@mui/x-date-pickers-pro/TimeRangePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterDateFns parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterDateFnsBase parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterDateFnsJalali parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterDayjs parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterLuxon parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterMoment parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterMomentHijri parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/AdapterMomentJalaali parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DateCalendar parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DateField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DatePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DateTimeField parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DateTimePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DayCalendarSkeleton parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DesktopDatePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DesktopDateTimePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DesktopTimePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/DigitalClock parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/LocalizationProvider parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/MobileDatePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/MobileDateTimePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/MobileTimePicker parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/MonthCalendar parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/MultiSectionDigitalClock parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/PickerDay2 parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/PickersActionBar parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/x-date-pickers/PickersCalendarHeader parsed: 0B^(0.00%) gzip: 0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against eb4cb86

codspeed-hq · 2025-07-18T12:50:00Z

CodSpeed Performance Report

Merging #18845 will not alter performance

_{Comparing bernardobelchior:improve-scatter-perf-dataset-processing (eb4cb86) with master (de2de2e)¹}

Summary

✅ 10 untouched benchmarks

No successful run was found on master (73a6acd) during the generation of this report, so de2de2e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

JCQuintas

Can we have a test regression test for it?

JCQuintas · 2025-07-21T10:38:38Z

packages/x-charts/src/LineChart/seriesConfig/extremums.ts

-  const minX = Math.min(...(axis.data ?? []));
-  const maxX = Math.max(...(axis.data ?? []));


Btw, despite the error thrown, the issue here is probably not a recursion issue, but too many arguments 😆

bernardobelchior · 2025-07-21T11:57:44Z

Can we have a test regression test for it?

Sure

[charts] Improve large dataset performance in scatter chart

e8477e5

bernardobelchior added performance type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jul 18, 2025

Another approach

ee9d159

bernardobelchior added 4 commits July 18, 2025 14:50

Remove unused fn

e59f9cd

Use hasOwn

e707a91

Fix axis extremums crashing on large data sets

e9a1e90

Revert series filtering

47fdb84

bernardobelchior changed the title ~~[charts] Improve large dataset performance in scatter chart~~ [charts] Fix crash when rendering large scatter dataset Jul 21, 2025

bernardobelchior marked this pull request as ready for review July 21, 2025 10:12

bernardobelchior requested review from alexfauquette and JCQuintas as code owners July 21, 2025 10:12

JCQuintas reviewed Jul 21, 2025

View reviewed changes

Abstract and add tests

eb4cb86

bernardobelchior requested a review from JCQuintas July 21, 2025 11:58

JCQuintas approved these changes Jul 21, 2025

View reviewed changes

bernardobelchior merged commit b06f069 into mui:master Jul 21, 2025
23 checks passed

bernardobelchior deleted the improve-scatter-perf-dataset-processing branch July 21, 2025 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[charts] Fix crash when rendering large scatter dataset #18845

[charts] Fix crash when rendering large scatter dataset #18845

Uh oh!

bernardobelchior commented Jul 18, 2025 •

edited

Loading

Uh oh!

mui-bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

JCQuintas left a comment

Uh oh!

JCQuintas Jul 21, 2025

Uh oh!

bernardobelchior Jul 21, 2025

Uh oh!

bernardobelchior commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

		const minX = Math.min(...(axis.data ?? []));
		const maxX = Math.max(...(axis.data ?? []));

Uh oh!

[charts] Fix crash when rendering large scatter dataset #18845

[charts] Fix crash when rendering large scatter dataset #18845

Uh oh!

Conversation

bernardobelchior commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

codspeed-hq bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #18845 will not alter performance

Summary

Footnotes

Uh oh!

JCQuintas left a comment

Choose a reason for hiding this comment

Uh oh!

JCQuintas Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

bernardobelchior Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

bernardobelchior commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

bernardobelchior commented Jul 18, 2025 •

edited

Loading

mui-bot commented Jul 18, 2025 •

edited

Loading

codspeed-hq bot commented Jul 18, 2025 •

edited

Loading