Skip to content

[charts-pro] Allow disabling the copy of styles in charts export #18753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

[charts-pro] Allow disabling the copy of styles in charts export #18753

merged 1 commit into from
Jul 9, 2025

Conversation

bernardobelchior
Copy link
Member

Related to #17447 (comment).

Allow disabling the copy of styles in charts export.

@bernardobelchior bernardobelchior force-pushed the charts-export-copy-styles branch from e2094af to 32ed0ec Compare July 9, 2025 14:27
@mui-bot
Copy link

mui-bot commented Jul 9, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18753--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Total Size Change: 🔺+380B(0.00%) - Total Gzip Change: 🔺+240B(+0.01%)
Files: 122 total (0 added, 0 removed, 10 changed)

Show details for 100 more bundles (22 more not shown)

@mui/x-charts-pro parsed: 🔺+38B(+0.01%) gzip: 🔺+28B(+0.02%)
@mui/x-charts-pro/BarChartPro parsed: 🔺+38B(+0.01%) gzip: 🔺+26B(+0.03%)
@mui/x-charts-pro/ChartContainerPro parsed: 🔺+38B(+0.02%) gzip: 🔺+24B(+0.04%)
@mui/x-charts-pro/ChartDataProviderPro parsed: 🔺+38B(+0.02%) gzip: 🔺+20B(+0.04%)
@mui/x-charts-pro/FunnelChart parsed: 🔺+38B(+0.02%) gzip: 🔺+23B(+0.03%)
@mui/x-charts-pro/Heatmap parsed: 🔺+38B(+0.02%) gzip: 🔺+23B(+0.03%)
@mui/x-charts-pro/LineChartPro parsed: 🔺+38B(+0.01%) gzip: 🔺+29B(+0.03%)
@mui/x-charts-pro/PieChartPro parsed: 🔺+38B(+0.02%) gzip: 🔺+28B(+0.04%)
@mui/x-charts-pro/RadarChartPro parsed: 🔺+38B(+0.02%) gzip: 🔺+17B(+0.03%)
@mui/x-charts-pro/ScatterChartPro parsed: 🔺+38B(+0.01%) gzip: 🔺+22B(+0.03%)
@mui/x-charts parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartsToolbarPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartZoomSlider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/BarChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartContainer parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartDataProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsAxisHighlight parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsClipPath parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsGrid parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLabel parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLegend parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsOverlay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsReferenceLine parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsSurface parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsText parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsTooltip parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsXAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsYAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/Gauge parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/LineChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/PieChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/RadarChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ScatterChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/SparkLineChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/Toolbar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid-premium parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid-premium/DataGridPremium parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid-pro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid-pro/DataGridPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-data-grid/DataGrid parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDateFnsJalali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDayjs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterLuxon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMoment parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMomentHijri parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMomentJalaali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangeCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay2 parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopDateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/LocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileDateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputDateRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputDateTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/PickersRangeCalendarHeader parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputDateRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputDateTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/StaticDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/TimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFnsBase parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFnsJalali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDayjs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterLuxon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMoment parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMomentHijri parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMomentJalaali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateTimeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DayCalendarSkeleton parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DigitalClock parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/LocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MonthCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MultiSectionDigitalClock parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickerDay2 parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickersActionBar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickersCalendarHeader parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 32ed0ec

@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jul 9, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 9, 2025

CodSpeed Performance Report

Merging #18753 will not alter performance

Comparing bernardobelchior:charts-export-copy-styles (32ed0ec) with master (d9a463e)

Summary

✅ 10 untouched benchmarks

@bernardobelchior bernardobelchior marked this pull request as ready for review July 9, 2025 15:02
@bernardobelchior bernardobelchior merged commit c4cad52 into mui:master Jul 9, 2025
27 checks passed
@bernardobelchior bernardobelchior deleted the charts-export-copy-styles branch July 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette is a code owner

Assignees
No one assigned
Labels
scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardobelchior @mui-bot @JCQuintas