-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[charts] Increase data points in chart benchmarks #18714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Increase data points in chart benchmarks #18714
Conversation
Deploy preview: https://deploy-preview-18714--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: ▼-8.93KB(-0.07%) - Total Gzip Change: ▼-1.79KB(-0.04%) Show details for 100 more bundles (22 more not shown)@mui/x-data-grid-premium/DataGridPremium parsed: ▼-1.5KB(-0.28%) gzip: ▼-313B(-0.21%) |
CodSpeed Performance ReportMerging #18714 will degrade performances by 82.42%Comparing Summary
Benchmarks breakdown
|
d875141
to
c877c90
Compare
74c2f41
to
8841359
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice title improvements as well 😆
I reverted those 😅 didn't want to add the number of data points in the title because incrementing/decrementing the number of data points would mean a new benchmark would be created and we'd lose history. |
Related to #12960.
Increase data points in bar, line and scatter chart benchmarks, so we can better see how performance scales with greater number of data points.
Also added area chart benchmark to ensure we benchmark that use case as well.