-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[infra] Updates release script to fetch latest major version from upstream #18552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Updates release script to fetch latest major version from upstream #18552
Conversation
…egrates it into changelog generation
Deploy preview: https://deploy-preview-18552--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 🔺+80B(0.00%) Show details for 100 more bundles (22 more not shown)@mui/x-charts parsed: 0B(0.00%) gzip: 0B(0.00%) |
…mes functions for clarity
scripts/createReleasePR.mjs
Outdated
if (aPrereleaseParts[0] === 'alpha' && bPrereleaseParts[0] === 'beta') { | ||
return -1; | ||
} | ||
if (aPrereleaseParts[0] === 'beta' && bPrereleaseParts[0] === 'alpha') { | ||
return 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"alpha" already comes before "beta" when comparing using localeCompare
, so we don't need this special case.
> 'alpha'.localeCompare('beta')
-1
"rc" also comes after "beta", so using localeCompare
should work for most cases:
> 'beta'.localeCompare('rc')
-1
…x/release-preparation
Cherry-pick PRs will be created targeting branches: v7.x |
This updates the release preparation script with a new function to fetch the latest major version and some adjustments regarding creating previous major version prs.