Skip to content

[DataGrid] Do not call preProcessEditCellProps() if cell is not editable based on isCellEditable() #18405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

[DataGrid] Do not call preProcessEditCellProps() if cell is not editable based on isCellEditable() #18405

merged 2 commits into from
Aug 7, 2025

Conversation

nusr
Copy link
Contributor

@nusr nusr commented Jun 17, 2025

fix #17856

edit

@nusr
[data grid] fix the error when editing a cell
ceeebbf 
Signed-off-by: Steve Xu <stevexugc@gmail.com>
@zannager zannager added the scope: data grid Changes related to the data grid. label Jun 17, 2025
@michelengelen michelengelen added the type: bug It doesn't behave as expected. label Jul 2, 2025
michelengelen
michelengelen reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... :shipit:

@michelengelen
Copy link
Member

@arminmeh should we backport this to v7 as well? Seems like an easy enough cherry-pick to do that, right?

@mui-bot
Copy link

mui-bot commented Jul 2, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18405--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 🔺+282B(0.00%) - Total Gzip Change: 🔺+69B(0.00%)
Files: 122 total (0 added, 0 removed, 6 changed)

Show details for 100 more bundles (22 more not shown)

@mui/x-data-grid parsed: 🔺+47B(+0.01%) gzip: 🔺+11B(+0.01%)
@mui/x-data-grid-premium parsed: 🔺+47B(+0.01%) gzip: 🔺+11B(+0.01%)
@mui/x-data-grid-premium/DataGridPremium parsed: 🔺+47B(+0.01%) gzip: 🔺+12B(+0.01%)
@mui/x-data-grid-pro parsed: 🔺+47B(+0.01%) gzip: 🔺+9B(+0.01%)
@mui/x-data-grid-pro/DataGridPro parsed: 🔺+47B(+0.01%) gzip: 🔺+19B(+0.01%)
@mui/x-data-grid/DataGrid parsed: 🔺+47B(+0.01%) gzip: 🔺+7B(+0.01%)
@mui/x-charts parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/BarChartPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartContainerPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartDataProviderPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartsToolbarPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ChartZoomSlider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/FunnelChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/Heatmap parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/LineChartPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/PieChartPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/RadarChartPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/ScatterChartPro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/BarChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartContainer parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartDataProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsAxisHighlight parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsClipPath parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsGrid parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLabel parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLegend parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsLocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsOverlay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsReferenceLine parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsSurface parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsText parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsTooltip parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsXAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ChartsYAxis parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/Gauge parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/LineChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/PieChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/RadarChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/ScatterChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/SparkLineChart parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-charts/Toolbar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDateFnsJalali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterDayjs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterLuxon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMoment parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMomentHijri parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/AdapterMomentJalaali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangeCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateRangePickerDay2 parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopDateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/DesktopTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/LocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileDateTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MobileTimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputDateRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputDateTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/MultiInputTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/PickersRangeCalendarHeader parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputDateRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputDateTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/SingleInputTimeRangeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/StaticDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers-pro/TimeRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFnsBase parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDateFnsJalali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterDayjs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterLuxon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMoment parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMomentHijri parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/AdapterMomentJalaali parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateTimeField parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DayCalendarSkeleton parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DesktopTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/DigitalClock parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/LocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MobileTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MonthCalendar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/MultiSectionDigitalClock parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickerDay2 parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickersActionBar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/x-date-pickers/PickersCalendarHeader parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against ffd0daf

arminmeh
arminmeh reviewed Jul 7, 2025
View reviewed changes
packages/x-data-grid/src/hooks/features/editing/useGridRowEditing.ts
@@ -459,7 +459,12 @@ export const useGridRowEditing = (
}

columns
.filter((column) => column.editable && !!column.preProcessEditCellProps && deleteValue)
.filter((column) => {
const isCellEditable = apiRef.current.getCellParams(id, column.field).isEditable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that above, while reducing columns to get newProps we also have this check.
It would be good to filter out columns based on this before both and use the result, to repeat this check 2 times

@arminmeh
Copy link
Contributor

arminmeh commented Jul 7, 2025

@arminmeh should we backport this to v7 as well? Seems like an easy enough cherry-pick to do that, right?

agree

@arminmeh arminmeh added feature: Editing Related to the data grid Editing feature needs cherry-pick The PR should be cherry-picked to master after merge. v7.x labels Jul 7, 2025
@johnatfondion
Copy link

@arminmeh @michelengelen when can we expect this to be merged?

@arminmeh arminmeh changed the title [data grid] fix the error when editing a cell [DataGrid] Do not call preProcessEditCellProps if cell is not editable based on isCellEditable() Aug 7, 2025
@arminmeh arminmeh changed the title [DataGrid] Do not call preProcessEditCellProps if cell is not editable based on isCellEditable() [DataGrid] Do not call preProcessEditCellProps() if cell is not editable based on isCellEditable() Aug 7, 2025
@arminmeh arminmeh merged commit 30fb917 into mui:master Aug 7, 2025
28 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2025

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Aug 7, 2025
@nusr @michelengelen @web-flow
[DataGrid] Do not call preProcessEditCellProps() if cell is not edi…
3ce46c5 
…table based on `isCellEditable()` (#18405)

Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Aug 7, 2025
Merged
@arminmeh arminmeh mentioned this pull request Aug 7, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh left review comments

@michelengelen michelengelen michelengelen approved these changes

Assignees
No one assigned
Labels
feature: Editing Related to the data grid Editing feature needs cherry-pick The PR should be cherry-picked to master after merge. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected. v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] preProcessEditCellProps triggered for cells which are not currently editable according to isCellEditable
6 participants
@nusr @michelengelen @mui-bot @arminmeh @johnatfondion @zannager