-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[charts] Add grouped axes demo #17848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for adding a type label to the PR! 👍 |
Deploy preview: https://deploy-preview-17848--material-ui-x.netlify.app/ Updated pages: |
82d13ce
to
2c242dc
Compare
CodSpeed Performance ReportMerging #17848 will not alter performanceComparing Summary
|
Most of the time those exemples looks like their is a real axis (here the monthsand a fake one (quarters) for display purpose. I'm wondering is instead of hacking a multiple axes system, we should provide a recipe about "This is how to create your custom axis". |
Depending on the result it might be simpler to have this demo instead of a custom axis. |
Yeah, I think we should, but I don't think that's a quick win. Looking at the work being done in If this is going to require a significant amount of effort, I don't think I can take this at the moment, so we need to decide whether we merge this demo, and pick this up later with the goal of creating a long-term solution for this problem. What do you think? |
Rather than showing how to create a custom Though it might be overkill 🤔, as this is not a huge use-case. 😆 |
You mean create it in the library and export it? I think it makes sense long term, but I'm already working on the toolbar and zoom, don't want to spread myself too thin 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hacky, but a clean solution would require to reconsider the internals 👍
Could you create an issue the different limitations and the solution found by other libraries to support this case. It could be a nice v9 feature? |
Done: #17931 |
Fixes #17839.
Add grouped axes demo. To achieve this, I added the axis ID to the class names so it's easier to target the given axis.
I'm not very fond of the hack to make every third tick bigger than normal, but
line
elements'x
andy
properties cannot be styled using CSS.