[charts] Add population pyramid demo #17652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
6d17265 to
a060d50
Compare
|
Deploy preview: https://deploy-preview-17652--material-ui-x.netlify.app/ Updated pages: |
JCQuintas
approved these changes
May 2, 2025
CodSpeed Performance ReportMerging #17652 will not alter performanceComparing Summary
|
alexfauquette
approved these changes
May 2, 2025
Comment on lines
2
to
3
| import { BarChart } from '@mui/x-charts/BarChart'; | ||
| import { Stack, Typography } from '@mui/material'; |
There was a problem hiding this comment.
Suggested change
| import { BarChart } from '@mui/x-charts/BarChart'; | |
| import { Stack, Typography } from '@mui/material'; | |
| import Stack from '@mui/material/Stack'; | |
| import Typography from '@mui/material/Typography'; | |
| import { BarChart } from '@mui/x-charts/BarChart'; |
| ]} | ||
| xAxis={[ | ||
| { | ||
| valueFormatter: (d: number) => `${numberFormatter.format(Math.abs(d))}`, |
There was a problem hiding this comment.
Maybe the axis will be easier to read
Suggested change
| valueFormatter: (d: number) => `${numberFormatter.format(Math.abs(d))}`, | |
| valueFormatter: (d: number) => `${numberFormatter.format(Math.abs(d) / 1000 )}k`, |
There was a problem hiding this comment.
Used k for thousands and M for million:
Comment on lines
47
to
63
| const suffixes = [ | ||
| { value: 1e6, symbol: 'M' }, | ||
| { value: 1e3, symbol: 'k' }, | ||
| ]; | ||
|
|
||
| const suffix = suffixes.find((s) => Math.abs(number) >= s.value); | ||
|
|
||
| if (!suffix) { | ||
| return new Intl.NumberFormat('en-US').format(number); | ||
| } | ||
|
|
||
| const formattedValue = new Intl.NumberFormat('en-US', { | ||
| minimumFractionDigits: 0, | ||
| maximumFractionDigits: 1, | ||
| }).format(number / suffix.value); | ||
|
|
||
| return formattedValue + suffix.symbol; |
There was a problem hiding this comment.
I think you can get it with less effort ;)
Suggested change
| const suffixes = [ | |
| { value: 1e6, symbol: 'M' }, | |
| { value: 1e3, symbol: 'k' }, | |
| ]; | |
| const suffix = suffixes.find((s) => Math.abs(number) >= s.value); | |
| if (!suffix) { | |
| return new Intl.NumberFormat('en-US').format(number); | |
| } | |
| const formattedValue = new Intl.NumberFormat('en-US', { | |
| minimumFractionDigits: 0, | |
| maximumFractionDigits: 1, | |
| }).format(number / suffix.value); | |
| return formattedValue + suffix.symbol; | |
| return new Intl.NumberFormat('en-US', { notation: 'compact' }).format(number); |
There was a problem hiding this comment.
Much better, thank you 😄
bernardobelchior
added a commit
to bernardobelchior/mui-x
that referenced
this pull request
May 2, 2025
This was referenced May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a population pyramid demo with data for South Korea in 2022.
Data source: KOSIS.