Skip to content

[DataGrid] Fix apiRef not being passed on onCellClick params #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

[DataGrid] Fix apiRef not being passed on onCellClick params #17335

merged 3 commits into from
Apr 24, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 12, 2025 •
edited
Loading

closes #16866

@sai6855 sai6855 marked this pull request as draft April 12, 2025 12:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@sai6855 sai6855 changed the title [DataGrid] Fix Cell event handlers props have null|undefined API refe… [DataGrid] Fix Cell event handlers props have null|undefined API reference Apr 12, 2025
@sai6855 sai6855 added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. labels Apr 12, 2025
@mui-bot
Copy link

mui-bot commented Apr 12, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17335--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 09746ac

@sai6855 sai6855 requested a review from Copilot April 12, 2025 12:50
Copilot
Copilot AI reviewed Apr 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/x-data-grid/src/hooks/features/rows/useGridParamsApi.ts:78

  • Replacing 'null as any' with 'apiRef.current' should correctly pass the API instance to the cell event parameters. Verify that apiRef.current is available at this point to avoid potential runtime issues.
api: apiRef.current,

packages/x-data-grid-pro/src/tests/events.DataGridPro.test.tsx:126

  • The test now passes the API reference as expected; ensure that this change consistently reflects the updated behavior of the production code.
api: apiRef.current,

@sai6855 sai6855 changed the title [DataGrid] Fix Cell event handlers props have null|undefined API reference [DataGrid] Fix apiRef not being passed on onCellClick params Apr 12, 2025
@sai6855 sai6855 marked this pull request as ready for review April 12, 2025 13:48
@sai6855 sai6855 requested a review from michelengelen April 12, 2025 13:48
@sai6855
Copy link
Contributor Author

sai6855 commented Apr 24, 2025

ping @michelengelen

michelengelen
michelengelen approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@michelengelen michelengelen added needs cherry-pick The PR should be cherry-picked to master after merge. v7.x labels Apr 24, 2025
@michelengelen michelengelen merged commit 2b10901 into mui:master Apr 24, 2025
25 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@sai6855 @web-flow
[DataGrid] Fix apiRef not being passed on onCellClick params (#17335)
44422fd
@github-actions github-actions bot mentioned this pull request Apr 24, 2025
Merged
arminmeh pushed a commit that referenced this pull request May 27, 2025
@sai6855 @arminmeh
[DataGrid] Fix apiRef not being passed on onCellClick params (#17335)
ed0eebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@michelengelen michelengelen michelengelen approved these changes

Assignees
No one assigned
Labels
needs cherry-pick The PR should be cherry-picked to master after merge. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected. v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Cell event handlers props have null|undefined API reference
3 participants
@sai6855 @mui-bot @michelengelen