Fix fatal error in REST API response when an image has no attachment metadata. #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checking sizes
felixarntz
reviewed
Oct 28, 2022
There was a problem hiding this comment.
@mehulkaklotar Fix generally looks reasonable, but please add a unit test for the bug, so that we can verify it is fixed.
In the test, you can use the rest_prepare_attachment to e.g. make $data['media_details'] an object. With that test, we should then verify whether the old code would fail vs the new code would pass.
…ponse when metadata is not present
|
@felixarntz I have added the new unit test for checking I have used the REST controller's |
felixarntz
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bug is very unlikely to happen as it depends on attachment metadata. It is assumed that metadata should always be present for the attachment but when metadata is deleted from DB, we should ensure proper error handling by checking the data from REST.
Fixes #567
Relevant technical choices
Added more checks for
media_detailsin response of REST API for attachmentsChecklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.