Theme: Add ordering to patterns. #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
reviewed
Jul 15, 2021
| } | ||
|
|
||
| return ( | ||
| <div className="pattern-select-control"> |
There was a problem hiding this comment.
This should use the same name as the component/folder, so either the class should be pattern-order-select or the component should be pattern-select-control (but that sounds like you're selecting a pattern).
52e7405 to
a3dbdc9
Compare
75d939e to
8ff8e0e
Compare
- Since it can contain more than a menu, use "navigation" - Use primary and secondary in place of left/right - it's not left/right on smaller screens or in RTL - Move the menu & select styles into their CSS files - Use primary/secondary div wrappers to make the layout CSS less dependent on specific content
8ff8e0e to
416cadb
Compare
ryelle
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to sort patterns based on 2 dimensions:
In the future, we hope to add support for
Featuredcategories.Fixes #161
Needs Resolution
Currently, block patterns don't start with the meta key:
wporg-pattern-favoritesset. This means that when we run the sorting query it will only return the patterns that have favorites. That may not be the experience we are looking for. In order to correct it, we'll need to set a default value. Should weregister_post_metaand set the default value to0?Example:
Screenshots
How to test the changes in this Pull Request:
/