Writing Flow: Shorter writing prompt #29611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -29 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Hi Joen. @jasmussen We discussed the issue during a design triage. Here is a link to the discussion: |
mtias
approved these changes
Mar 25, 2021
db7369d to
8d5aa09
Compare
|
@gziolo I'm struggling with making this string translatable. Do you have a moment to point me in the right direction? I'd like something like: |
|
A couple of things that I noticed as well, in order of importance:
One crazier idea would be to show a few 'greyed out blocks' like heading 2, paragraph, or bullets for new users to click on when their page is blank but I'm not sure this would be a better experience (would have to play with it to see how it felt). |
@ellatrix essentially a question about how the |
This is going to be dependant on the theme, as it would inherit the font and style of whichever theme it was seen on.
We actually tried this way back, and although the current design has improved vastly since then, ultimately we found that if the blocks were pre-selected, it quickly became dead weight, and if they were chosen by "frecency", it messed with muscle memory.
Yep, I'll try that as the next step here. Once we have that working we can look at next steps. Thank you! |
mtias
approved these changes
Mar 31, 2021
|
Created trac patch here: https://core.trac.wordpress.org/ticket/52948 |
|
Suggested dev note: |
|
I added the dev note to remind of the trac ticket. I don't think we need one. :) |
|
@jasmussen Done in #30393. |
7 tasks
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Apr 2, 2021
Recently merged, WordPress/gutenberg#29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor. Props Joen, SergeyBiryukov. Fixes #52948. git-svn-id: https://develop.svn.wordpress.org/trunk@50647 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 2, 2021
Recently merged, WordPress/gutenberg#29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor. Props Joen, SergeyBiryukov. Fixes #52948. git-svn-id: https://develop.svn.wordpress.org/trunk@50647 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 2, 2021
Recently merged, WordPress/gutenberg#29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor. Props Joen, SergeyBiryukov. Fixes #52948. Built from https://develop.svn.wordpress.org/trunk@50647 git-svn-id: http://core.svn.wordpress.org/trunk@50259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Apr 2, 2021
Recently merged, WordPress/gutenberg#29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor. Props Joen, SergeyBiryukov. Fixes #52948. Built from https://develop.svn.wordpress.org/trunk@50647 git-svn-id: https://core.svn.wordpress.org/trunk@50259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
geriux
pushed a commit
that referenced
this pull request
May 21, 2021
* Crudely fork web implementation to remove invariant violations * WIP - Better UI for testing. Reset Autocomplete on delete content * Use a synthetic event to bind onEnter to the autocompletion * Mobile - Move onEnter logic to native Rich Text * Simplify event conformance in native RichText * Remove native variant of block-editor autocomplete This adds the block completer * Use Platform variant to wrap text on native, leaving web unchanged * Extract autocomplete functions * Merge autocomplete variants, and create an autocomplete ui variant * WIP - add Popover library and begin experimenting * Move optional from this to function * WIP - Popover changes * Extract default useItems hook from autocomplete ui * Rename extracted ui for consistency * Remove Popover library. Add UI for the slash inserter selector * Remove lodash usage * Fix preventDefault on Android * Simplify customEditableOnKeyDown stubs * Rename autocompletion slot fill and move to mobile components * Reset scroll position when autocomplete items change * Adjust styles for BlurView (for iOS - needs Android changes) * Update autocompletion item container view styles for Android * Update autocomplete styles * Fix order of imports * Put feature behind __DEV__ flag * Remove mobile wrapper since it no longer uses the label attribute to render the block name * Add missing line break * Update active item styles * Revert "Put feature behind __DEV__ flag" This reverts commit 528a83f. * Add slash-inserter e2e test * Update light-mode active background color for slash complete option * Update placeholder text to hint the slash inserter * Slash inserter animation and active item color update * Styles cleanup * Pass isVisible to useCallback * Adjust autocompleter animation timing * Remove redundant text decoration * Adjust colors * Use shorter writing prompt This is taken from #29611 * Make test description more specific Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> * Styles update * Mobile: Update default text placeholder, fix autocompleter position in Android * Use I with serif for italic format library icon This is to distinguish the character from the slash character to avoid confusion with the slash inserter (especially with the new writing prompt that says to type "/"). * Mobile - Add Slash inserter e2e tests * Unify e2e files * Revert placeholders change * Mark AutocompletionItemsSlot and AutocompletionItemsFill as __unstable * Update styles to BEM naming * Revert "Use I with serif for italic format library icon" This reverts commit c251037. * Fix slash inserter e2e * Fix e2e test on Android * Extract slash inserter assertion into separate function * Extract platform variants for BackgroundView to separate files Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com>
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
Recently merged, WordPress/gutenberg#29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor. Props Joen, SergeyBiryukov. Fixes #52948. Built from https://develop.svn.wordpress.org/trunk@50647 git-svn-id: http://core.svn.wordpress.org/trunk@50259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current writing prompt is rather verbose when duplicated (#13599), and even when there's only one:
This reduces it:
I like the shorter prompt as it indicates that there's an empty block. The writing feels implied with the reduced block borders.
If we are fans, this needs a core patch (see also #5549).
Checklist: