Skip to content

Add a "Write your story" filter. #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2018
Merged

Add a "Write your story" filter. #5549

merged 1 commit into from
Mar 10, 2018

Conversation

markjaquith
Copy link
Member

fixes #5466

Description

Adds a write_your_story filter to match the enter_title_here filter, so the default block appender prompt can be customized.

How Has This Been Tested?

Verified that this updates the prompt:

add_filter( 'write_your_story', function() {
	return 'Say something';
});

Types of changes

  1. New filter write_your_story.
  2. <DefaultBlockAppender /> accepts placeholder argument.

@gziolo gziolo added the [Feature] Extensibility The ability to extend blocks or the editing experience label Mar 10, 2018
@aaronjorbin aaronjorbin self-assigned this Mar 10, 2018
aduth
aduth approved these changes Mar 10, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aduth aduth merged commit 8a4d644 into WordPress:master Mar 10, 2018
@gziolo
Copy link
Member

gziolo commented Mar 10, 2018 •
edited by markjaquith
Loading

Just noting that it is not going to work properly with the encoded characters. See related issue with the title prompt: #4933.

@danielbachhuber danielbachhuber mentioned this pull request Mar 29, 2018
Merged
@earnjam earnjam mentioned this pull request Aug 17, 2018
Closed
@jasmussen jasmussen mentioned this pull request Mar 8, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjorbin aaronjorbin aaronjorbin approved these changes

@aduth aduth aduth approved these changes

Assignees

@aaronjorbin aaronjorbin

Labels
[Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a "Write your story" Filter
4 participants
@markjaquith @gziolo @aaronjorbin @aduth