Move legacy-widget block over to edit-widgets package #25371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +453 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Tested and works as described. Code is mostly moving things around. One new thing is that registerBlock is now exported cc @youknowriad
youknowriad
reviewed
Sep 16, 2020
| @@ -16,6 +16,14 @@ _This package assumes that your code will run in an **ES2015+** environment. If | |||
|
|
|||
| <!-- START TOKEN(Autogenerated API docs) --> | |||
|
|
|||
| <a name="registerBlock" href="#registerBlock">#</a> **registerBlock** | |||
There was a problem hiding this comment.
I don't think that's a good API to expose, it's too confusing as it's the same as wp.blocks.registerBlock with minor differences (loading metadata), we should just duplicate it in edit-widgets instead.
6 tasks
This was referenced Sep 17, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the legacy-widget block is only registered in the widgets editor as discussed in #24900. While this may change at some point in the future, as of now it's unclear how it could work in the post editor.
How has this been tested?
Types of changes
Non-breaking change
Checklist: