File Block: Fix PDF preview on URLs containing query parameters #70915
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @MichaelCastelbuono. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks for the PR!
Did you try to use the getFilename utility?
import { getFilename } from '@wordpress/url';
const isPdf = getFilename( newMedia.url )?.toLowerCase().endsWith( '.pdf' );|
Thank you for reviewing! I hadn’t tried it, but this does look cleaner and more robust. I’ll try it out and update with the change. |
…Press#70915) * fix: detect PDF urls with query strings in file block * fix: use `getFilename` to fetch filename from media URL Unlinked contributors: MichaelCastelbuono. Co-authored-by: BugReportOnWeb <devasheeshkaul@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Closes #70908
This PR fixes the issue in the File block where PDF files with query parameters are not recognised as PDFs, resulting in the embedded preview not rendering.
Why?
Some media storage plugins or CDN setups generate signed PDF URLs with query parameters for access control. These still point to valid PDFs, but the current logic fails to detect them as such, disabling the embedded preview.
How?
Updated the PDF detection logic to use
URLAPI. This safely extracts the pathname from the media URL, ignoring query parameters and hash fragments.Testing Instructions
Manual Testing with Code Injection
If not able to set up cloud storage, test manually with:
Screenshots or screencast