-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Closed
Labels
[Block] FileAffects the File BlockAffects the File Block[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
Because of the current logic in the file block a PDF url must end with .pdf
to be considered a PDF. Thus, if a url has query params it is not considered a PDF and you lose the ability to embed. This is particularly common when you are using a plugin that uses signed urls for documents stored in s3-like storage.
Step-by-step reproduction instructions
- Install an s3-like plugin such as WP Offload Media
- Upload PDF to media catalog
- Change the privacy setting from public to private
- Edit page and add a file block referencing the file
- Because the url has query params no embed is possible
Screenshots, screen recording, code snippet
No response
Environment info
- WordPress version 6.8.2.
Please confirm that you have searched existing issues in the repo.
- Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
- Yes
Please confirm which theme type you used for testing.
- Block
- Classic
- Hybrid (e.g. classic with theme.json)
- Not sure
Metadata
Metadata
Assignees
Labels
[Block] FileAffects the File BlockAffects the File Block[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended