Media library modal: Fix plugin incompatibilities with MediaUpload filter #70648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @sunnykasera3107. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -74 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 9, 2025
|
Thanks for the quick fix 🙇🏻 |
|
Unfortunately it looks like there are some CI errors with the PHP unit tests: Kinda random. |
I'm seeing those a lot lately. Our Docker env is becoming unstable 😢 |
Yeah, it's curious it happens in CI, but not in my local env so much. I've tried re-running the tests a few times now, but I'll try some more 😄 |
|
I don't think we'll be getting this to pass by re-running the tests. This is the previous discussion around this error - wp-env Error while running docker compose command. Having said that, it's quite a generic error, so it might not always be the same issue. |
6 tasks
|
Slightly different error on the latest try - When testing locally I don't get this at all, so it's very unusual. Other CI tests also not experiencing the same issue. |
…mponent to prevent upstream errors in plugins
5e70d44 to
31b1b6f
Compare
|
The same checks also started failing on my old PR. It could be an upstream issue. |
Might be a debian package server issue... seems to be up. 🤔 I tried cleaning out the local repository of retrieved package files using I really don't know why though 😄 |
When I asked copilot to explain the error it also said to do that. 😄 It seems like it clears the local cache of downloaded packages. I think we should do it, and then we can also remove that line later if the error seems to go away. I also wonder if clearing the caches here will help - https://github.com/WordPress/gutenberg/actions/caches |
I just tried deleting the cache for this PR, now re-running again. |
Looks like we're in the red 🤣 |
'Approaching' the limit, like approaching an event horizon. |
|
Still failed after deleting the github actions cache.
I've pushed this change 🤞 |
|
Still failed. I think this PR is cursed as Ramon's version #70652 seems to be passing. |
|
🤞🏻 they're passing now. Maybe it's just flakey. |
|
I cleared the actions caches again, maybe that did the trick. Just a waiting game now. |
talldan
added a commit
that referenced
this pull request
Jul 9, 2025
…lter (#70648) * Media library modal: Ensure modal is passed into filter as a class component to prevent upstream errors in plugins * Revert media upload invalidation change * Clean packages before running apt-get update - kudos @ramonjd ---- Unlinked contributors: sunnykasera3107. Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
|
Thanks for your help getting this across the line folks! |
|
@talldan thanks for bringing this to my attention. Agreed that I actually just saw #70405 yesterday by chance and was wondering why it was solved this way. #70397 mentions stale data when dragging images into the canvas and then opening the media inserter. This has nothing to do with the The |
It was another case that I noticed while working on the problem, it is mentioned in the testing steps in the PR.
Yeah, it's admittedly subpar. Maybe there are other integration points for cache invalidation, but I didn't spot any obvious ones.
I think you can also invalidate There's another issue I've noticed since working on #70405. Some code might interact with media items via a call like In the long run I think it might be an option to try relocating some of the code from the |
2 tasks
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
…lter (#70648) * Media library modal: Ensure modal is passed into filter as a class component to prevent upstream errors in plugins * Revert media upload invalidation change * Clean packages before running apt-get update - kudos @ramonjd ---- Unlinked contributors: sunnykasera3107. Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #70647
Some users started experiencing errors after Gutenberg 21.1. Example here - https://wordpress.org/support/topic/unexpected-error-after-updating-to-21-1-0/.
From my testing, this seems to be caused by an incompatibility between gutenberg and the AMP plugin (cc @westonruter, @swissspidy). There may also be other plugins that have similar issues.
After #70405 the
MediaUploadfilter instead started receiving a function component instead of a class component.I think this is the relevant code in AMP - https://github.com/ampproject/amp-wp/blob/7b4ed4c001cdc0fbf9adb518fb0b8e1ddebf4d5a/assets/src/block-editor/components/with-media-library-notice.js.
Notice that it calls
extendon theInitialMediaUploadarg from the filter, so when a function component started being used this failed. This code seems like it has the potential to cause lots of general incompatibilities, for example if other plugins use the filter and modify the return results.To temporarily fix this I'm proposing to partially revert #70405 and release a hotfix with that change.
Testing Instructions