Skip to content

Site Logo: Refactor the media panel to use ToolsPanel #70599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

Site Logo: Refactor the media panel to use ToolsPanel #70599

merged 4 commits into from
Jul 7, 2025

Conversation

himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Jul 3, 2025 •
edited
Loading

What?

Closes #67936
Comment: #67936 (comment)

Refactors the "Media" panel of the Site Logo block to use ToolsPanel instead of PanelBody.

Why?

Part of #67813 - This change ensures consistency with other inspector panels throughout the editor.

Testing Instructions

  • Create a new post or page
  • Add a Site Logo block
  • Set a site logo image
  • Open the block inspector and verify that the "Media" panel appears with ToolsPanel styling
  • Test the reset functionality and verify if it works like before
  • Verify that the panel behaves correctly

Screenshots

Before After

@himanshupathak95 himanshupathak95 changed the title Site Logo: Refactor the media panel to ToolsPanel Site Logo: Refactor the media panel to use ToolsPanel Jul 3, 2025
@himanshupathak95 himanshupathak95 force-pushed the fix/site-logo-media-toolspanel branch from 5824271 to cc8f401 Compare July 3, 2025 09:52
@himanshupathak95 himanshupathak95 marked this pull request as ready for review July 3, 2025 09:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Jul 3, 2025
t-hamano
t-hamano reviewed Jul 4, 2025
View reviewed changes
@himanshupathak95
Copy link
Contributor Author

Thanks @t-hamano, for the follow-up. I completely missed out on the read-only part. Here's how it looks now -

Screen.Recording.2025-07-07.at.12.34.55.mov

t-hamano
t-hamano approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 8a9281f into WordPress:trunk Jul 7, 2025
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 21.2
Development

Successfully merging this pull request may close these issues.

Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody
3 participants
@himanshupathak95 @t-hamano @Mamaduka