Social Link Block: Add context to service names #70413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
Size Change: +44 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
fbd98f4 to
2b19efa
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2b19efa to
8d1617f
Compare
|
Flaky tests detected in 8d1617f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16591336554
|
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 31, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: alexclassroom <alexclassroom@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds context to service names of the Social Link block.
Why?
Service name strings may already exist in the codebase and have a different meaning; we need to prevent unintentional localization.
How?
Use the
_xfunction and add a context. This will prevent not only the typical mistranslation problem with "Medium," but also future mistranslations, such as "Pocket" and "Threads" being used as nouns rather than service names.Testing Instructions